fix #298362: pressing number after mouse click works for a different line in "Italian" styled tablature staff #5524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harmoniker1
force-pushed
the
italian-tab
branch
from
eef06c3
to
b31f76e
Compare
Harmoniker1
changed the title
Harmoniker1
force-pushed
the
italian-tab
branch
from
b31f76e
to
7ba7bb4
Compare
…line in "italian" styled tablature staff Resolves: https://musescore.org/node/298362. This is because the string number is reversed for number pressing (for upside-down tablature staves) while in fact it isn't needed. So a physStringToVisual() is called in this patch to eliminate the effect. See https://musescore.org/en/node/298362#comment-965223.
Harmoniker1
force-pushed
the
italian-tab
branch
from
7ba7bb4
to
a349116
Compare
anatoly-os
pushed a commit
that referenced
this pull request
Dec 25, 2019
fix #298362: pressing number after mouse click works for a different line in "Italian" styled tablature staff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/node/298362.
This is because the string number is reversed for number pressing (for upside-down tablature staves) while in fact it isn't needed. So a
physStringToVisual()is called in this patch to eliminate the effect. See https://musescore.org/en/node/298362#comment-965223.