fix #298564: shift of manually adjusted slur on small staff #5538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I should add, this change actually doesn't make things worse compatibility-wise. Since we were already reading offsets relative to the score, slurs saved in a build with these changes actually load correctly in older versions. And similarly, scores saved in older versions open the same (erroneous) way in builds with these changes, since we have been reading relative to score all along. Also, I realize I can make a test for this by putting the adjusted slur in the source file for the test. Then just loading & saving will demonstrate the problem, or not. So, I'll update this shortly. |
Resolves: https://musescore.org/en/node/298564 We currently write the offsets for slur grips scaled according to the staff, but we read them scaled according to the score. That's because on read, the slur hasn't been added yet, so the track is not set. I fixed the exact same issue for other lines in musescore@812a281 but slurs have their own own read/write and I neglected to make the corresponding change for them. This fixes the issue by explicitly scaling according to score. Note there are other reasons why this makes sense, see other comments in musescore#4827 for more information on the scaling of offsets and other properties.
MarcSabatella
force-pushed
the
298564-slur-shift
branch
from
84ef6ed
to
29a9ee0
Compare
|
(I updated with mtest, should be good to go now) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/298564
We currently write the offsets for slur grips
scaled according to the staff, but we read them
scaled according to the score. That's because
on read, the slur hasn't been added yet, so the track is not set.
I fixed the exact same issue for other lines in
812a281
but slurs have their own read/write and I neglected
to make the corresponding change for them.
This fixes the issue by explicitly scaling according to score.
Note there are other reasons why this makes sense,
see other comments in #4827
for more information on the scaling of offsets and other properties.
I couldn't see a good way to create an automated test for this, as it relies on manual adjustment via editDrag(). Perhaps the recent enhancements to mtest make this more feasible?