Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brassband #5571

Closed
wants to merge 3 commits into from
Closed

Brassband #5571

wants to merge 3 commits into from

Conversation

kmbgit
Copy link

@kmbgit kmbgit commented Dec 30, 2019

Resolves: Remove "brass quintet" from PR#5567

#5567

There's some confusion in the instruments.xml file about whether "genre" means "musical genre" (e.g. "jazz") or "ensemble genre" (e.g. "orchestra", "concert band", "marching band"). Taking the latter meaning, "Brass Band" is a legitimate ensemble genre because a lot of music is written for this instrument grouping and the grouping contains unique instruments (most notably Bb Baritone, Eb Bass, Bb Bass).

I originally submitted this change under PR#5567 which also included "Brass Quintet", but I agree with the argument that X-tets will lead to exponential grown of the category list so I've removed it here.

Use "x" letter to fill the checkboxes below like [x]

  • [ x] I signed CLA
  • [ x] I made sure the code in the PR follows the coding rules
  • [ x] I made sure the code compiles on my machine
  • [ x] I made sure there are no unnecessary changes in the code
  • [ x] I made sure the title of the PR reflects the core meaning of the issue you are solving
  • [ x] I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • [ x] I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

Make life easier for finding brass band and brass quintet instruments by adding genres underneath "Brass".
Also create a "Bb Baritone" instrument because that's what brass bands call the "baritone horn" - I should know, I play one!
@Jojo-Schmitz
Copy link
Contributor

Rebase needed. Also squashing into just one commit

@vpereverzev vpereverzev added the archived PRs that have gone stale but could potentially be revived in the future label Nov 30, 2020
@vpereverzev
Copy link
Member

Archived due to inactivity (but we can re-open it again once the author will come back)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
archived PRs that have gone stale but could potentially be revived in the future strings Affects translatable strings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants