Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: Remove "brass quintet" from PR#5567
#5567
There's some confusion in the instruments.xml file about whether "genre" means "musical genre" (e.g. "jazz") or "ensemble genre" (e.g. "orchestra", "concert band", "marching band"). Taking the latter meaning, "Brass Band" is a legitimate ensemble genre because a lot of music is written for this instrument grouping and the grouping contains unique instruments (most notably Bb Baritone, Eb Bass, Bb Bass).
I originally submitted this change under PR#5567 which also included "Brass Quintet", but I agree with the argument that X-tets will lead to exponential grown of the category list so I've removed it here.
Use "x" letter to fill the checkboxes below like [x]