Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for xaphoon instrument #5591

Merged

Conversation

eduardomourar
Copy link
Contributor

@eduardomourar eduardomourar commented Jan 6, 2020

Implements a feature request: https://musescore.org/en/node/11028

In order to create a new staff with Xaphoon (Pocket sax) instrument, we need to add it to the instruments XML file. This is based in the file from user AirW (found here).

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@anatoly-os anatoly-os merged commit e5ec5e5 into musescore:master Jan 13, 2020
@anatoly-os anatoly-os added this to the MuseScore 3.4 milestone Jan 13, 2020
@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Jan 13, 2020

Sorry, I missed some changes that are IMHO needed to the instrument names (capitals, hyphens, flat sign), see and check #5603

@eduardomourar eduardomourar deleted the feature/add-xaphoon-instrument branch January 13, 2020 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants