Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #291758 - [Musicxml Export] - Tbox and Vbox after measure 1 don't export #5606

Merged
merged 2 commits into from Feb 17, 2020

Conversation

lvinken
Copy link
Contributor

@lvinken lvinken commented Jan 14, 2020

… export

Resolves: https://musescore.org/en/node/291758

Export text frames as MusicXML words and all vertical frames as MusicXML credit-words. Popular request, also required to better support Braille transcriptions.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@dmitrio95
Copy link
Contributor

Could these new test files be added to tst_mxml_io.cpp to have the relevant tests running on Travis?

@dmitrio95 dmitrio95 changed the title fix #291758 - [Musicxml Export] - Tbox and Vbox after measure 1 don't… fix #291758 - [Musicxml Export] - Tbox and Vbox after measure 1 don't export Feb 14, 2020
@lvinken
Copy link
Contributor Author

lvinken commented Feb 15, 2020

I think that could indeed be done, although I am not quite sure yet how much effort would be required or when I could do that.

@dmitrio95
Copy link
Contributor

Doesn't the existing mxmlMscxExportTestRef already do what is needed for these tests?

@lvinken
Copy link
Contributor Author

lvinken commented Feb 16, 2020

Indeed you are right, I had forgotten about that. In my defence, that function was implemented by Igevorse five years ago :-). Will make the required changes, squash the commits and do a forced push.

@lvinken lvinken force-pushed the 291758-musicxml-tbox-vbox-export branch from 981f114 to 8e36f39 Compare February 16, 2020 15:32
@lvinken
Copy link
Contributor Author

lvinken commented Feb 16, 2020

Done, also included some cleanup and a rebase.

@dmitrio95 dmitrio95 merged commit 85fab59 into musescore:master Feb 17, 2020
@lvinken lvinken deleted the 291758-musicxml-tbox-vbox-export branch March 8, 2020 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants