Simplify version-specific configuration in build scripts #5621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrio95
force-pushed
the
build-version-config
branch
from
6a56e28
to
c728c10
Compare
dmitrio95
force-pushed
the
build-version-config
branch
from
c728c10
to
29e5a76
Compare
igorkorsukov
approved these changes
Apr 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A proposed way to simplify version branches configuration so commits like 5e9b1a6 would potentially be limited to changing up to 4 lines in
config.cmake(and possibly some changes inappveyor.yml). Currently CI scripts read some of build settings directly fromCMakeLists.txt, such scripts were corrected to allowconfig.cmakedefine the necessary variables depending on certain conditions (which was necessary to automate most of changes in 5e9b1a6-like commits).The changes are not tested on CI build services yet, Windows-related changes may need more attention as I didn't test them locally.