Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #281503 : enable compilation with make on macOS #5660

Merged
merged 1 commit into from
Jan 8, 2021

Conversation

AntonioBL
Copy link
Contributor

Resolves: https://musescore.org/en/node/281503
This PR enables compilation of MuseScore under MacOS without installing the full XCode IDE, but only the command line tools.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • [ N/A ] I created the test (mtest, vtest, script test) to verify the changes I made

@AntonioBL
Copy link
Contributor Author

This PR adds two pairs of make commands:
release-cl + install-cl for release build
debug-cl + installdebug-cl for debug build

The compilation requirements are the same as usual Mac compilation, but instead of installing XCode one should run xcode-select --install and select not to install XCode (see for example http://osxdaily.com/2014/02/12/install-command-line-tools-mac-os-x/ )

@riaanvn
Copy link
Contributor

riaanvn commented Feb 5, 2020

For someone who already has Xcode installed, do you have instructions for switching from using Xcode to using command-line tools / make?
How would I know that it is safe to delete Xcode?

@AntonioBL
Copy link
Contributor Author

I think you could use command-line tools and make even when keeping Xcode, by simply switching the target of xcode-select, see here:
https://macops.ca/developer-binaries-on-os-x-xcode-select-and-xcrun/
apparently, it seems possible to switch to using pure command-line tools by setting DEVELOPER_DIR environment variable to /Library/Developer/CommandLineTools, see at the bottom of that page. (I remember after deleting Xcode I had to use xcode-select to switch to the correct folder since it was keeping the old Xcode value).

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Nov 9, 2020

rebase needed (?)
Maybe rebase to 3.x (first)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants