Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Musicxml import fix todo's ws #5710

Merged
merged 2 commits into from
Feb 14, 2020
Merged

Conversation

lvinken
Copy link
Contributor

@lvinken lvinken commented Feb 14, 2020

Resolves:
https://musescore.org/en/node/300542
https://musescore.org/en/node/301113

Fix old regressions in file mscore/importmxmlpass1.cpp marked with "TODO WS". Leftovers from Werner's migrations in early 2017. Restores the import from MusicXML of word font and page size and margins.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@dmitrio95 dmitrio95 merged commit de371a5 into musescore:master Feb 14, 2020
@lvinken lvinken deleted the musicxml-fix-todo-ws branch February 15, 2020 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants