Timeline optimizations #5730
Merged
Timeline optimizations #5730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! What about the inability to cooperate with dark mode? |
mscore/timeline.cpp
Outdated
| return; | ||
| } | ||
|
|
||
| const bool layoutAll = layoutChanged && (state.startTick().negative() || state.endTick().negative()); |
There was a problem hiding this comment.
See https://travis-ci.org/musescore/MuseScore/jobs/652005292#L2630-L2636, "class Ms::Fraction has no member named negative"
There was a problem hiding this comment.
Looks like I forgot to commit some changes, as always. Will update PR soon.
This pull request doesn't address that, it is solely about performance of using Timeline. |
dmitrio95
force-pushed
the
timeline-opt
branch
from
5b6e993
to
700003a
Compare
Partial redrawing of meta information rows is not implemented here. Also avoid rebuilding timeline grid on opening a score if timeline is invisible.
74 tasks
igorkorsukov
added a commit
to igorkorsukov/MuseScore
that referenced
this pull request
Feb 12, 2021
… parts with text/hbo/vbox
vpereverzev
pushed a commit
that referenced
this pull request
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As full timeline refactoring (#4542) has not been finished as for this moment, this PR tries to fix the most prominent performance issues of the old Timeline implementation. In general, the following optimizations are implemented:
Although Timeline performance is still not ideal with this PR and could be optimized further, this PR should still hopefully make Timeline more usable for people working on relatively large scores. Users who don't use Timeline should also benefit from this PR due to the last optimization for invisible Timeline.