fix #302603: Changing "Direction" has no effect on bowing symbols #5851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmcclinch
force-pushed
the
302603-turned-accidentals
branch
from
f853656
to
325e0bf
Compare
Resolves: https://musescore.org/en/node/302603. Many articulations have names like "fermataAbove" and "fermataBelow". The flipping mechanism currently only supports articulations with names in this form. But some articulations have names like "stringsUpBow" and "stringsUpBowTurned". This commit adds the ability to flip articulations with names in this form also.
mattmcclinch
force-pushed
the
302603-turned-accidentals
branch
from
325e0bf
to
834404d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/302603.
Many articulations have names like "fermataAbove" and "fermataBelow". The flipping mechanism currently only supports articulations with names in this form. But some articulations have names like "stringsUpBow" and "stringsUpBowTurned". This commit adds the ability to flip articulations with names in this form also.