fix #303403: play repeats button doesn't reflect stored settings #5900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jojo-Schmitz
force-pushed
the
play-repeats
branch
2 times, most recently
from
52314fb
to
3a3f320
Compare
while at it fix the same bug for the pan button too, and, with that now working, remove the corresponding entries from the advanced prerefences
Jojo-Schmitz
force-pushed
the
play-repeats
branch
from
3a3f320
to
255488c
Compare
Jojo-Schmitz
changed the title
anatoly-os
reviewed
Apr 8, 2020
| @@ -445,7 +445,7 @@ void MuseScore::preferencesChanged(bool fromWorkspace) | |||
| { | |||
| updateExternalValuesFromPreferences(); | |||
|
|
|||
| setPlayRepeats(MScore::playRepeats); | |||
There was a problem hiding this comment.
Why did you decide to remove the call of all other operations included to this method, and left only the checked state setter?
Isn't the call of setPlayRepeats necessary here?
There was a problem hiding this comment.
It doesn't seem to be as per my testing
There was a problem hiding this comment.
Maybe, but it didn't work, not for showing the current real status
igorkorsukov
approved these changes
Apr 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://musescore.org/en/node/303403 (and came up in https://musescore.org/en/node/303316#comment-989518)
While at it fix the same bug for the pan button too (which just came up in https://musescore.org/en/node/303874#comment-992514)
Not sure why I didn't notice those 2 bugs and fixed along with #5378