Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mtests under Windows MSVC #6028

Merged
merged 1 commit into from May 18, 2020
Merged

Conversation

AntonioBL
Copy link
Contributor

Fixes running of mtests under Windows, when compiled with MSVC.
The "workspaces" folder was missing for the new palette tests, and the executable used for scripting tests was searching for "workspaces" folder as well.
No changes in the mtest instructions.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • [N/A] I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • [N/A] I created the test (mtest, vtest, script test) to verify the changes I made

@anatoly-os anatoly-os merged commit f978f1d into musescore:3.x May 18, 2020
anatoly-os added a commit that referenced this pull request May 20, 2020
fix mtests under Windows MSVC
@AntonioBL AntonioBL deleted the winmtests branch October 26, 2020 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants