Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove forgotten comment #6031

Merged
merged 1 commit into from
Jun 22, 2020
Merged

remove forgotten comment #6031

merged 1 commit into from
Jun 22, 2020

Conversation

ecstrema
Copy link
Contributor

@ecstrema ecstrema commented May 3, 2020

As pointed out by this comment

@@ -462,8 +457,11 @@ bool MasterScore::saveFile(bool generateBackup)
// tr("Removing old backup file %1 failed").arg(backupName));
}
}
//
// step 2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "step 2" should probably remain in the same position.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, I completely forgot that one...
However, I am not sure that it really should. The step has moved, so why keep the name of it at some other place?

@anatoly-os anatoly-os merged commit 2a9a4c6 into musescore:3.x Jun 22, 2020
@ecstrema ecstrema deleted the backup branch December 8, 2020 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants