fix man-page to mention changed default DPI setting for PNGs export #6066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
follow up for 2d83656, which changed that from 300 to 72.0 * 5
7 tasks
mirabilos
approved these changes
May 9, 2020
mscore/musescore.cpp
Outdated
| parser.addOption(QCommandLineOption( "score-meta", "Export score metadata to JSON document and print it to stdout")); | ||
| parser.addOption(QCommandLineOption( "score-mp3", "Generates mp3 for the given score and export the data to a single JSON file, print it to stdout")); | ||
| parser.addOption(QCommandLineOption( "score-parts-pdf", "Generates parts data for the given score and export the data to a single JSON file, print it to stdout")); | ||
| parser.addOption(QCommandLineOption( "score-transpose", "Transposes the given score and exports the data to a single JSON file, print it to stdout", "options")); |
There was a problem hiding this comment.
prints because all other verbs are also in this form
There was a problem hiding this comment.
I see "Print...", "Use...", "Start...", "Dump...", "Export...", "Set...", "Specify", "Load...", "Execute...", "Save...", "Revert...", "Process...", "Enable...", "Override...", "Run...", "Don't use...", "Install...".
So the majority is not, but "Used with...", "Generates...", "Transposes", so needs fixing.
|
So the majority is not, but "Used with...", "Generates...", "Transposes", so needs fixing.
Ah, I looked in the context, which has Generates, Transposes, etc.
OK fix it the other way round then ☻
|
|
still needed for master too |
29 tasks
anatoly-os
added a commit
that referenced
this pull request
May 20, 2020
fix man-page to mention changed default DPI setting for PNGs export
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up for 2d83656 (so since MuseScore 3.4), which changed that from 300 to 72.0 * 5