Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #304353: melisma line overlaps next syllable | collect_artifacts #6081

Merged
merged 1 commit into from
Jun 2, 2020

Commits on May 18, 2020

  1. fix #304353: melisma line overlaps next syllable | collect_artifacts

    Resolves: https://musescore.org/en/node/304353
    
    Melisma lines are spanners and therefore not laid out until
    well after note spacing and measure widths have been settled.
    This means there is no way for the melisma line to influence spacing.
    And yet, it needs to, if we want to avoid potential collisions.
    
    Because we cannot use the melisma line itself to affect spacing,
    this code borrows the approach used for lyrics themselves:
    calling addHorizontalSpacing() to reserve space for the melisma line
    when calculating the shape of the ChordRest.
    
    In order to do this, we need to know if a ChordRestr ends a melisma.
    So I have added a helper function, isMelismaEnd(), to check this.
    I also fixed a couple of issues in the calculation
    of the length of the melisma line.
    One was that we used the width of the start rather than end note
    (in cases where the next note also has a lyric, which is common).
    Another is that we were deliberately overshooting
    the right edge of the end note,
    whereas Gould says to end at the note.
    MarcSabatella committed May 18, 2020
    Configuration menu
    Copy the full SHA
    9bb5f0c View commit details
    Browse the repository at this point in the history