Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix vtest artifact when failing to generate images and add the possib… #6092

Merged
merged 1 commit into from May 18, 2020

Conversation

AntonioBL
Copy link
Contributor

…ility to skip the failure signal for approved vtest changes

Resolves: N/A

This PR properly renames the ref images even in the case in which the PR vtests cannot be generated.
Moreover, this PR adds the possibility of having the "green check" also for PRs that change vtests.
This is done when the label 'vtests' is applied to the PR, for example when vtests have been reviewed and approved by a person with the correct permissions for adding such a label.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • [N/A] I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • [N/A] I created the test (mtest, vtest, script test) to verify the changes I made

…ility to skip the failure signal for approved vtest changes
@AntonioBL
Copy link
Contributor Author

Note:
Every time a label (not only 'vtests') is added or remove from the PR, the vtest workflow is relaunched.

@anatoly-os anatoly-os merged commit 06f4c16 into musescore:3.x May 18, 2020
anatoly-os added a commit that referenced this pull request May 20, 2020
fix vtest artifact when failing to generate images and add the possib…
@AntonioBL AntonioBL deleted the vtests3 branch October 26, 2020 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants