#305502 : Osc plugin controller #6095
Conversation
|
Please squash those commits into just one and change the commit title to start with "fix #305502:", for the the corresponding issue to automatically get marked fixed once this PR got merged. In case you want this included in MuseScore 3.x, please rebase to that branch. |
Yes i'm Enzo Pain on musescore.org. I'm fixing my mistakes and rebasing to the MuseScore 3.x branch. |
NozBead
force-pushed
the
osc-plugin-controller
branch
9 times, most recently
from
d6f9689
to
174d9bd
Compare
NozBead
force-pushed
the
osc-plugin-controller
branch
2 times, most recently
from
38ab4f4
to
174d9bd
Compare
NozBead
force-pushed
the
osc-plugin-controller
branch
from
174d9bd
to
98a4c79
Compare
|
That was a bit of a rough ride ;-) |
|
I'm still a bit new to git :D ! |
|
That seems to have done the trick |
There was a problem hiding this comment.
You added some functionality in third party libraries. I know that we tend to refrain from doing that as much as possible, however, if they are cloned into the repo, it's probably because we still need to modify them sometimes. The others will know more about it.
Also, you where is the documentation for using what you just did with osc? How could i find what to do if I wanted to call a plugin?
NozBead
force-pushed
the
osc-plugin-controller
branch
from
98a4c79
to
c08cfb3
Compare
NozBead
force-pushed
the
osc-plugin-controller
branch
from
c08cfb3
to
15f8f62
Compare
Changes to respect musescore coding rules switched == nullptr to !, removed empty lines, fixed indent thirdparty code formating indention changes
NozBead
force-pushed
the
osc-plugin-controller
branch
from
15f8f62
to
a9607c5
Compare
|
Will this be merged? Looking forward to it :) |
|
I guess it may need to get ported to the master branch, for inclusion in MuseScore 4 |
After a lot of plugin projects I felt blocked by the lack of network communication between a plugin and an exterior app so i imagined a way of doing that kind of things. Duplicate of musescore#6095 (I can't seem to attribute it to @NozBead)
After a lot of plugin projects I felt blocked by the lack of network communication between a plugin and an exterior app so i imagined a way of doing that kind of things. Duplicate of musescore#6095 (I can't seem to attribute it to @NozBead)
After a lot of plugin projects I felt blocked by the lack of network communication between a plugin and an exterior app so i imagined a way of doing that kind of things. Duplicate of musescore#6095 (I can't seem to attribute it to @NozBead)
|
In order for me to be able to attribute this to you in my #9000, please tell me your email address (via PM, if need be) |
After a lot of plugin projects I felt blocked by the lack of network communication between a plugin and an exterior app so i imagined a way of doing that kind of things. Duplicate of musescore#6095, fix an MSVC compiler warning it introduced. (I can't attribute s commit to @NozBead)
|
|
Thanks, done |
After a lot of plugin projects I felt blocked by the lack of network communication between a plugin and an exterior app so i imagined a way of doing that kind of things. Duplicate of musescore#6095, fix an MSVC compiler warning it introduced.
After a lot of plugin projects I felt blocked by the lack of network communication between a plugin and an exterior app so i imagined a way of doing that kind of things. Duplicate of musescore#6095, fix an MSVC compiler warning it introduced.
After a lot of plugin projects I felt blocked by the lack of network communication between a plugin and an exterior app so i imagined a way of doing that kind of things. Duplicate of musescore#6095, fix an MSVC compiler warning it introduced.
After a lot of plugin projects I felt blocked by the lack of network communication between a plugin and an exterior app so i imagined a way of doing that kind of things. Duplicate of musescore#6095, fix an MSVC compiler warning it introduced.
After a lot of plugin projects I felt blocked by the lack of network communication between a plugin and an exterior app so i imagined a way of doing that kind of things. Duplicate of musescore#6095, fix an MSVC compiler warning it introduced.
After a lot of plugin projects I felt blocked by the lack of network communication between a plugin and an exterior app so i imagined a way of doing that kind of things. Duplicate of musescore#6095, fix an MSVC compiler warning it introduced.
After a lot of plugin projects I felt blocked by the lack of network communication between a plugin and an exterior app so i imagined a way of doing that kind of things. Duplicate of musescore#6095, fix an MSVC compiler warning it introduced.
After a lot of plugin projects I felt blocked by the lack of network communication between a plugin and an exterior app so i imagined a way of doing that kind of things. Duplicate of musescore#6095, fix an MSVC compiler warning it introduced.
After a lot of plugin projects I felt blocked by the lack of network communication between a plugin and an exterior app so i imagined a way of doing that kind of things. Duplicate of musescore#6095, fix an MSVC compiler warning it introduced.
Resolves : #305502
After a lot of plugin projects I felt blocked by the lack of network communication between a plugin and an exterior app so i imagined a way of doing that kind of things.