Fix #4867: Filling measure with rests be affected by time signature #6123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How can this not change any vtest? |
|
vtests don't test the result of running a command, just what a score looks like immediately on loading. |
|
Exactly. This does not try to “correct” rest durations already present in a score. Nor should it. |
njvdberg
approved these changes
May 27, 2020
29 tasks
anatoly-os
added a commit
that referenced
this pull request
Aug 11, 2020
mattmcclinch
added a commit
to mattmcclinch/MuseScore
that referenced
this pull request
Sep 4, 2020
…er Note in triplet to Eight causes corruption A change was made in PR musescore#6123 to use toRhythmicDurationList() rather than toDurationList() in Score::setRest(), so that compound beats are split correctly in the case of a compound meter. But this splitting of compound beats should not happen when setting rests withing a tuplet.
mattmcclinch
added a commit
to mattmcclinch/MuseScore
that referenced
this pull request
Sep 10, 2020
…er Note in triplet to Eight causes corruption A change was made in PR musescore#6123 to use toRhythmicDurationList() rather than toDurationList() in Score::setRest() and Score::makeGap(), so that compound beats are split correctly in the case of a compound meter. But this splitting of compound beats should not happen when setting rests withing a tuplet.
vpereverzev
pushed a commit
that referenced
this pull request
Oct 5, 2020
…er Note in triplet to Eight causes corruption A change was made in PR #6123 to use toRhythmicDurationList() rather than toDurationList() in Score::setRest() and Score::makeGap(), so that compound beats are split correctly in the case of a compound meter. But this splitting of compound beats should not happen when setting rests withing a tuplet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/4867.
This makes use of the toRhythmicDurationList() function in Score::setRest() and Score::makeGap(). Since the resulting duration list is constructed based on the relative tick within the measure, the rests will never have to be added in the reverse order, which was something that had to be done when using toDurationList().