fix #279926: shift+click to select similar #6137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A common request is for click/shift+click to select similar elements. So for example, click one lyric, shift+click another, would select all lyrics in that range. Currently, shift+click of anything but a note or rest simply selects the elements and loses the previous selection. This change catches that case, and if there is an element selected, and the selected element and the shift+clicked elements are same type, we build a range selection that encompasses thenm both, then run selectSimilarInRange. I also check if the two elements are in the same voice, and if so, I limit the selection to just that voice rather than all elements on that staff as would normally be the case. But aside from that, it also allows for selection across staves, so you can click an articulation on one staff, shift+click another on another staff, and all intervening articulations are selected.
12 tasks
njvdberg
approved these changes
May 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/279926
A common request is for click/shift+click to select similar elements.
So for example, click one lyric, shift+click another,
would select all lyrics in that range.
Currently, shift+click of anything but a note or rest
simply selects the elements and loses the previous selection.
This change catches that case, and if there is an element selected,
and the selected element and the shift+clicked elements are same type,
we build a range selection that encompasses thenm both,
then run selectSimilarInRange.
I also check if the two elements are in the same voice,
and if so, I limit the selection to just that voice
rather than all elements on that staff as would normally be the case.
But aside from that, it also allows for selection across staves,
so you can click an articulation on one staff,
shift+click another on another staff,
and all intervening articulations are selected.