fix #306371: wrong input position if last selected cR in voice >1 #6179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e > 1 Resolves: https://musescore.org/en/node/306371 When entering note input mode with no selection, we try to find a good location to start. Originally this was the top left visible CR of voice 1. A while ago I added code to favor the last selected CR, but since we were looking in voice 1 only, we never found it. Fix here is to check for voice >1 in lastSelected, and if so, find a CR in voice 0 instead. Alternative would be to go ahead and start note entry in voice 2, but to me this felt too surprising given we are talking about a case where nothing is in fact currently selected. People generally expect note input to start in voice 1 unless they explicitly selected something in voice 2.
anatoly-os
added a commit
that referenced
this pull request
Jun 8, 2020
fix #306371: wrong input position if last selected cR in voice >1
29 tasks
anatoly-os
added a commit
that referenced
this pull request
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/306371
When entering note input mode with no selection,
we try to find a good location to start.
Originally this was the top left visible CR of voice 1.
A while ago I added code to favor the last selected CR,
but since we were looking in voice 1 only, we never found it.
Fix here is to check for voice >1 in lastSelected, and if so,
find a CR in voice 0 instead.
Alternative would be to go ahead and start note entry in voice 2,
but to me this felt too surprising given we are talking about a case
where nothing is in fact currently selected.
People generally expect note input to start in voice 1
unless they explicitly selected something in voice 2.