Fix #308034: Add user line spacing to text inspector #6347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit title lacks "fix #308034:", and PR message should include that this resolves https://musescore.org/en/node/308034 |
elerouxx
force-pushed
the
text-user-linesp-inspect-3.x
branch
from
0e12b1e
to
a9fbd32
Compare
elerouxx
changed the title
elerouxx
force-pushed
the
text-user-linesp-inspect-3.x
branch
from
a9fbd32
to
a31ce63
Compare
elerouxx
commented
Jul 20, 2020
elerouxx
force-pushed
the
text-user-linesp-inspect-3.x
branch
2 times, most recently
from
9fc3929
to
f6503de
Compare
elerouxx
commented
Jul 22, 2020
elerouxx
force-pushed
the
text-user-linesp-inspect-3.x
branch
from
f6503de
to
2e41022
Compare
elerouxx
changed the title
elerouxx
force-pushed
the
text-user-linesp-inspect-3.x
branch
from
2e41022
to
c078a00
Compare
elerouxx
force-pushed
the
text-user-linesp-inspect-3.x
branch
from
c078a00
to
294eb68
Compare
igorkorsukov
added a commit
to igorkorsukov/MuseScore
that referenced
this pull request
Feb 8, 2021
vpereverzev
pushed a commit
that referenced
this pull request
Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://musescore.org/en/node/308034
Adds custom text line spacing control to Text Inspector and Text Styles
Spacing is in lines (li.)
The new property is a multiplier to the font's natural line spacing, in which
1.0 lineswould be the full natural spacing of the font (and MuseScore's current default), 0.5 lines would be half of this space and so on, in a similar way than most word processors deal with line spacing.This property was added for every Text Style and to the Text inspector.
Image shows the modified inspector and some text elements adjusted to different spacing.
Code review, feedback and testing will be greatly appreciated!