Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GSoC 2020: measure repeats #6365

Merged
merged 6 commits into from
Nov 22, 2020

Commits on Nov 20, 2020

  1. Re-enable NOBREAK with fixes and new functionality

    - Fix #279071: "Don't Break" element creates hole at end of system
    - Allow more than two measures to be grouped
    - Allow adding/toggling NOBREAK by clicking palette
    - Rename to "Group Measures"
    - Adjust placement of break symbols
    Co-authored-by: MarcSabatella <marc@outsideshore.com>
    IsaacWeiss committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    8c430e2 View commit details
    Browse the repository at this point in the history
  2. Bring measure.h and measure.cpp in line with new code guidelines

    - Public before private
    - Members prefixed with "m_"
    IsaacWeiss committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    a1b5567 View commit details
    Browse the repository at this point in the history
  3. Fix musescore#10220: Replace RepeatMeasure with MeasureRepeat, add su…

    …btypes 1/2/4
    
    - Draw with font symbols instead of QPainterPath
    - Automatically group measures and delete contents when adding MeasureRepeat
    - Bring measure.h and measure.cpp in line with new code guidelines
    - Hide rests by making measures (per MStaff) aware if they are part of measure repeat group
    - Keep measures and element in sync at all times by handling (preventing/warning/special-casing) many user actions
    - Add style options for numbering consecutive one-measure repeats
    IsaacWeiss committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    bcadc25 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2244111 View commit details
    Browse the repository at this point in the history
  5. Add/update tests for MMRests and MeasureRepeats

    MMRests:
    - Add vtests for old-style (all fonts), h-bar thickness and margin (Bravura)
    
    MeasureRepeats:
    - Add script tests for adding, cutting/copying with partial group selected, pasting into group, repeating selection from before group, executing split/join/insert/delete measure commands, adding repeat barlines, and adding time signature
    - Add mtests for parts, MIDI, and MusicXML import/export
    - Add vtests
    - Update ref files
    IsaacWeiss committed Nov 20, 2020
    Configuration menu
    Copy the full SHA
    129daed View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2020

  1. Configuration menu
    Copy the full SHA
    0777643 View commit details
    Browse the repository at this point in the history