Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #308281 : Blank upload dialog on MacOS Catalina + collect_artifacts #6378

Merged
merged 1 commit into from
Jul 28, 2020

Conversation

AntonioBL
Copy link
Contributor

@AntonioBL AntonioBL commented Jul 27, 2020

Resolves: https://musescore.org/en/node/308281

Apparently, QtWebEngine requires additional permissions to run under MacOS 10.15, see https://forum.qt.io/post/526704

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • [ N/A ] I created the test (mtest, vtest, script test) to verify the changes I made

@BernardGreenberg
Copy link

I, the original plaintiff, have verified that Antonio's executable really does solve the problem I reported.

@AntonioBL AntonioBL changed the title [WIP] fix #308281 : Blank upload dialog on MacOS Catalina + collect_artifacts fix #308281 : Blank upload dialog on MacOS Catalina + collect_artifacts Jul 27, 2020
@AntonioBL
Copy link
Contributor Author

( Thanks, BSG 😄 )

Additional note for the developers running MacOS Catalina:
I had to downgrade the XCode in the Github actions otherwise the artifacts would crash on start because of something Apple did to their version of OpenGL in 10.15 sdk.
See:
https://www.geeks3d.com/hacklab/20191214/geexlab-0-29-9-1-released-with-macos-10-15-catalina-support/
TheInfiniteKind/appbundler#70
https://github.com/google/filament/pull/1959/files
So, at the moment, a build of MuseScore made with the latest XCode will most probably crash on startup because of the "OpenGL can be called from the main thread only" limitation.

@BernardGreenberg
Copy link

This (OpenGL) issue looks like a disaster; does that cripple all Qt development toward Catalina, or only 5.9?

@AntonioBL
Copy link
Contributor Author

This (OpenGL) issue looks like a disaster; does that cripple all Qt development toward Catalina, or only 5.9?

Well, I really don't know for sure. I think Qt 5.14 could have some improvements in this field, but I didn't test it.

@anatoly-os anatoly-os merged commit 5fca8ef into musescore:3.x Jul 28, 2020
@anatoly-os
Copy link
Contributor

Manually merged to master (8f0f185)

anatoly-os added a commit that referenced this pull request Jul 28, 2020
fix #308281 : Blank upload dialog on MacOS Catalina + collect_artifacts
@AntonioBL AntonioBL deleted the macqtwebengine branch October 26, 2020 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants