Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #281639: Better handling of Clefs, Barlines on ossias and cutaway #6461

Merged
merged 1 commit into from
Dec 17, 2020

Conversation

elerouxx
Copy link
Contributor

@elerouxx elerouxx commented Aug 17, 2020

Partially Resolves: https://musescore.org/en/node/281639
(Brackets out of scope of this PR)

Fixes visibility of Bar Lines for Ossias or Cutaway scores.
The EndBarLine of an invisible measure will automatically show if next measure is visible and in the same system.
Span works as expected, no manual insert of bar line needed.
(Barlines can always be manually set to invisible, if desired)

Fixes showing courtesy clefs on invisible measures
On a cutaway staff, If a courtesy clef is added to the end of an empty measure, a short staff "trailer" will be created to display the clef. This allows clefs to be displayed on the first visible measure or after an invisible section of a cutaway staff.
(Clefs must be created manually by adding the clef to a whole measure, as always).

Before
image

After
image

As always, feedback and review will be appreciated.

*Some additional small fixes:

  • Dragging manually-added bar lines won't set the Global span anymore (which was probably the intention of the existing code)
  • Measure numbers will show even if measure is invisible or cut away from the system.
  • Spacers will always show, even on invisible measures, to avoid losing track of them on a cutaway score.*
  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • [] I created the test (mtest, vtest, script test) to verify the changes I made

@elerouxx
Copy link
Contributor Author

image
This was the only difference in visual tests (as expected)

@elerouxx elerouxx changed the title Fix #281639: Better handling of Clefs, Barlines and (not yet) brackets Fix #281639: Better handling of Clefs, Barlines on ossias and cutaway Sep 14, 2020
@elerouxx elerouxx force-pushed the cutaway-clefs-3.x branch 2 times, most recently from 6c45bf6 to 48228de Compare September 16, 2020 13:09
@elerouxx elerouxx force-pushed the cutaway-clefs-3.x branch 3 times, most recently from 0b4f087 to f3c8799 Compare November 23, 2020 12:49
@vpereverzev
Copy link
Member

Looking for rebase

@elerouxx
Copy link
Contributor Author

Looking for rebase

Done!

libmscore/segment.cpp Outdated Show resolved Hide resolved
@elerouxx
Copy link
Contributor Author

elerouxx commented Dec 1, 2020

Updated and ready.

elerouxx added a commit to elerouxx/MuseScore that referenced this pull request Dec 21, 2020
elerouxx added a commit to elerouxx/MuseScore that referenced this pull request Dec 21, 2020
igorkorsukov added a commit to igorkorsukov/MuseScore that referenced this pull request Feb 2, 2021
igorkorsukov added a commit to igorkorsukov/MuseScore that referenced this pull request Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants