-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #281639: Better handling of Clefs, Barlines on ossias and cutaway #6461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
af9be72
to
6ec54f7
Compare
6ec54f7
to
08b02cf
Compare
6c45bf6
to
48228de
Compare
48228de
to
617809d
Compare
0b4f087
to
f3c8799
Compare
Looking for rebase |
f3c8799
to
a8d14a4
Compare
Done! |
ecstrema
reviewed
Nov 30, 2020
ecstrema
reviewed
Nov 30, 2020
ypoissant
reviewed
Nov 30, 2020
ypoissant
reviewed
Nov 30, 2020
a8d14a4
to
87f2aad
Compare
Updated and ready. |
d78aec5
to
0690d16
Compare
0690d16
to
407c8c9
Compare
…sia | collect_artifacts
407c8c9
to
858bccc
Compare
7 tasks
elerouxx
added a commit
to elerouxx/MuseScore
that referenced
this pull request
Dec 21, 2020
6 tasks
elerouxx
added a commit
to elerouxx/MuseScore
that referenced
this pull request
Dec 21, 2020
elerouxx
added a commit
to elerouxx/MuseScore
that referenced
this pull request
Dec 21, 2020
vpereverzev
pushed a commit
that referenced
this pull request
Dec 22, 2020
7 tasks
igorkorsukov
added a commit
to igorkorsukov/MuseScore
that referenced
this pull request
Feb 2, 2021
igorkorsukov
added a commit
to igorkorsukov/MuseScore
that referenced
this pull request
Feb 2, 2021
igorkorsukov
added a commit
that referenced
this pull request
Feb 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially Resolves: https://musescore.org/en/node/281639
(Brackets out of scope of this PR)
Fixes visibility of Bar Lines for Ossias or Cutaway scores.
The EndBarLine of an invisible measure will automatically show if next measure is visible and in the same system.
Span works as expected, no manual insert of bar line needed.
(Barlines can always be manually set to invisible, if desired)
Fixes showing courtesy clefs on invisible measures
On a cutaway staff, If a courtesy clef is added to the end of an empty measure, a short staff "trailer" will be created to display the clef. This allows clefs to be displayed on the first visible measure or after an invisible section of a cutaway staff.
(Clefs must be created manually by adding the clef to a whole measure, as always).
Before
![image](https://user-images.githubusercontent.com/2843953/90351925-1d156600-e018-11ea-90c3-63278ee7c660.png)
After
![image](https://user-images.githubusercontent.com/2843953/90352385-9d889680-e019-11ea-95f4-bcd1509beafb.png)
As always, feedback and review will be appreciated.
*Some additional small fixes: