fix #309098: fix parts playback for chord symbols #6469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return hCh->mute() || hCh->soloMute(); | ||
| if (hCh) { //if there is a harmony channel | ||
| const Channel* pCh = h->masterScore()->playbackChannel(hCh); | ||
| return pCh->mute() || pCh->soloMute(); |
There was a problem hiding this comment.
Hah! So, the code we talked about was working correctly, but the soloMute was being ignored?
|
Thanks for doing this, I figured it had to be something simple but the mechanics of all this is too mysterious to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/309098
Makes chord symbols playback honor playback channel settings which is needed to play or mute them correctly when playing a part instead of the entire score.