Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Qt-5.2.0 for Windows #650

Closed
wants to merge 2 commits into from

Conversation

Jojo-Schmitz
Copy link
Contributor

After Linux and Mac now for Windows too

After Linux and Mac now for for Windows too
on Windows, but Mac and Linux are using 5.2 already anyway.
@mgavioli
Copy link
Contributor

If I understand the CMakeLists.txt contents correctly, this commit would change the minimum Qt required version to 5.2 for all platforms, not just for Windows.

In fact, I'm still happily using 5.1.0 to compile MuseScore on my Linux Mint 14 distro.

@Jojo-Schmitz
Copy link
Contributor Author

As far as I can see from the various sources and build files, Mac is using 5.2 and Linux is using 5.2.0-rc1, see Makefile, line 31: https://github.com/musescore/MuseScore/blob/master/Makefile#L31

But yes, it would mean 5.2 will be the minimum. And this is why I made it a separate commit ;-)
But it'd be good for consistency oif all platforms use the same Qt, wouldn't it?
And the minimum for Windows is 5.1.1 since quite a while (due to a bug with printing, if I remember correctly)

@wschweer
Copy link
Contributor

The meaning of QT_MIN_VERSION is to set the minimum version of Qt which is used by MuseScore. MuseScore does not use any Qt5.2 features and compiles with Qt5.1 so the current value is ok. This does not prevent you to use a later Qt version.

@wschweer wschweer closed this Jan 24, 2014
@Jojo-Schmitz
Copy link
Contributor Author

With the 1st commit of my PR, MuseScore can't get build for Windows with 5.1 anymore, without if can't get build with 5.2, so we're between a rock and a hard place here.
The requirement for all platforms to use 5.2 is not really 100% needed, but Mac nighly builds use it already, indication in the Makefile for the Linux build shows it does does too and on top Robert Leleu couldn't get the 64bit version for Linux to work without, as he recently wrote in the developers mailing list.
Anyway, I can resubmit with only the 1st commit, would that be OK?

@wschweer
Copy link
Contributor

I manually applied first patch.

@Jojo-Schmitz
Copy link
Contributor Author

OK, thanks, enough for me... will update the developers' handbook page for windows build to use 5.2 now.

@Jojo-Schmitz Jojo-Schmitz deleted the qt5.2-for-Windows branch January 24, 2014 10:49
@Jojo-Schmitz Jojo-Schmitz restored the qt5.2-for-Windows branch January 27, 2014 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants