Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #300340: Additive Time Signatures Do Not Appear Properly in the G… #6524

Merged
merged 1 commit into from Nov 30, 2020

Conversation

elerouxx
Copy link
Contributor

@elerouxx elerouxx commented Sep 2, 2020

…onville Font

Resolves: https://musescore.org/en/node/300340

Fixes a series of problems with spacing in which a sequence of glyphs is drawn as a string, and in particular, the 'advance' space value that was set to zero in case of a fallback glyph.
This includes sequence of time signature glyphs in certain fonts including Goinville, some sequences of glyphs that build mordents and ornaments, and some problems with dynamics with more than one glyph (ppp, fff).

For horizontal spacing:
_Found a call to ScoreFont::advance() that pointed to an override version that didn't compute the advance value from the fallbackFont. Because of this, the missing + glyph was drawn from the fallbackFont but its advance was set to zero.

For vertical spacing (when stretching the time signature):
_Found a call to ScoreFont::BBox() that pointed to an override version that didn't allow scaling in different horizontal and vertical dimensions.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • [N/A] I created the test (mtest, vtest, script test) to verify the changes I made

@elerouxx
Copy link
Contributor Author

elerouxx commented Sep 2, 2020

This vtest fail is actually a fix too. Looking closely to that mordent in musejazz
image

. In the reference render, the second half of the mordent slightly overlaps the middle vertical line (almost imperceptible).
As seen in detail (before/after):
image

@anatoly-os anatoly-os added the vtests This PR produces approved changes to vtest results label Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vtests This PR produces approved changes to vtest results
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants