Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add extended fermata symbols to MusicXML I/O #6560

Merged
merged 1 commit into from Oct 20, 2020
Merged

add extended fermata symbols to MusicXML I/O #6560

merged 1 commit into from Oct 20, 2020

Conversation

rettinghaus
Copy link
Contributor

@rettinghaus rettinghaus commented Sep 18, 2020 •
edited

This PR adds import/export for fermata symbols that were added to MusicXML 3.1 here: https://github.com/w3c/musicxml/pull/152/files

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I created the test (mtest, vtest, script test) to verify the changes I made

@RobFog
Copy link

RobFog commented Sep 18, 2020

cc @lvinken

cbjeukendrup
cbjeukendrup requested changes Sep 19, 2020
View reviewed changes
Copy link
Contributor

@cbjeukendrup cbjeukendrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! The only thing is that one } is missing in exportxml.cpp; see comment at line 2353.

importexport/musicxml/exportxml.cpp Outdated Show resolved Hide resolved
@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Oct 14, 2020 •
edited

Might be good enough for 3.5.2, even if not being a regression, but certainly is for 3.6

This was referenced Oct 14, 2020
Closed
Closed
@vpereverzev vpereverzev merged commit 490f321 into musescore:3.x Oct 20, 2020
@rettinghaus rettinghaus deleted the dev-fermatas branch December 1, 2020 16:15
igorkorsukov added a commit to igorkorsukov/MuseScore that referenced this pull request Feb 17, 2021
@igorkorsukov
ported musescore#6560 : add extended fermata symbols to MusicXML I/O
ea1d721
@igorkorsukov igorkorsukov mentioned this pull request Feb 17, 2021
Merged
vpereverzev pushed a commit that referenced this pull request Feb 17, 2021
@igorkorsukov @vpereverzev
ported #6560 : add extended fermata symbols to MusicXML I/O
716f71e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbjeukendrup cbjeukendrup cbjeukendrup requested changes

@Jojo-Schmitz Jojo-Schmitz Jojo-Schmitz approved these changes

@vpereverzev vpereverzev vpereverzev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rettinghaus @RobFog @Jojo-Schmitz @cbjeukendrup @vpereverzev