Prevent adding beam properties to rests #665
Conversation
|
That Travis error doesn't look like anything to do with us. |
|
That specific Travis failure is not related with the PR, but the build testing is currently failing anyway, since merging PR 661: PR page #661 - Travis report https://travis-ci.org/musescore/MuseScore/builds/17537479 |
|
Building of master seems fixed now... |
|
Whats the problem with beam properties on a rest? Actually rests have beam properties. |
|
This is supposed to fix #24412, http://musescore.org/en/node/24412 |
|
The only problem was my lack of understanding. |
| @@ -331,6 +331,8 @@ void Beam::layout1() | |||
| _up = _direction == MScore::UP; | |||
| } | |||
| else { | |||
| if (!c1) | |||
There was a problem hiding this comment.
As far as I understand the code, this change seems OK to me: if the beamed element is a rest, there is no stem, and computing its stem length makes no sense. I would even move the addition right before line 330, skipping the stem length computation regardless of _direction value.
|
http://musescore.org/en/node/24412 has been closed as being fixed in 51d8cbd |
or trying to layout a rest with a beam property.