Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #308726: Avoid rest offsets with slash notation #6757

Merged

Conversation

tobik
Copy link
Contributor

@tobik tobik commented Oct 25, 2020

Resolves: https://musescore.org/en/node/308726

Do not offset rests if slash notation is active anywhere in the chord

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@vpereverzev vpereverzev merged commit 528db84 into musescore:3.x Oct 25, 2020
igorkorsukov added a commit to igorkorsukov/MuseScore that referenced this pull request Feb 15, 2021
igorkorsukov added a commit that referenced this pull request Feb 15, 2021
@MarcSabatella
Copy link
Contributor

See https://musescore.org/en/node/318800 - I think this probably is what broke rests within the rhythmic slash notation. If I'm following this correctly, the original problem was that rests not in slash notation were being offset unnecessarily. Now, unfortunately, the rests that are in slash are not being offset either, and they definitely need to be (and were previously).

Probably the code added here needs to be skipped if the current rest is itself in slash notation. Well, at least if in voice 3 or 4, which are the ones that need to be offset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants