[MU4] Add support for triple sharp and triple flat #6762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 tasks
Jojo-Schmitz
force-pushed
the
triple-sharp-flat-master
branch
2 times, most recently
from
e17edcb
to
77126be
Compare
Jojo-Schmitz
force-pushed
the
triple-sharp-flat-master
branch
from
77126be
to
8203dcb
Compare
|
Don’t forget to add the two new |
|
Ah, that is the purpose of that file! So #6763 needs this too |
|
Joachim Schmitz dixit:
Ah, that is the purpose of that file!
Yes… which is also documented in length in the commit
message… which I also responded to you in the other PR ☻
|
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Oct 28, 2020
there rest (the symbols' translations, libmscore/sym.cpp) should come via merge (or a rebase)
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Oct 28, 2020
there rest (the symbols' translations, libmscore/sym.cpp) should come via merge (or a rebase)
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Oct 29, 2020
and adjust script for triple Sharp and -Flat, PR musescore#6762
igorkorsukov
pushed a commit
that referenced
this pull request
Nov 10, 2020
and adjust script for triple Sharp and -Flat, PR #6762
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SMuFL provides glyphs for triple sharp and triple flat, so they might as well be available to use in MuseScore. This involves adding 14 new TPCs and expanding the range of the AccidentalVal enum class.
This was requested on the forum topic in Triple sharps and triple flats (sort of, ignore the digressions into politics and key signatures).
See https://seanyeh.com/pages/alkans_triple_sharp/ for an example of a triple sharp being used in a piece of music from the Romantic period.
Counterpart for master to #6744.
Finally obsoletes #6002, (@mattmcclinch ?).