Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #312083: tempofield in new score wizard not accessible #6789

Merged
merged 1 commit into from Nov 14, 2020

Conversation

MarcSabatella
Copy link
Contributor

Resolves: https://musescore.org/en/node/312083

A quirk in Qt prevents screen readers from recognizing UI elements
that are part of groups that were disabled in the UI file.
Fix is to enable the group in the UI file
but then disable it in the code.

Resolves: https://musescore.org/en/node/312083

A quirk in Qt prevents screen readers from recognizing UI elements
that are part of groups that were disabled in the UI file.
Fix is to enable the group in the UI file
but then disable it in the code.
@@ -57,6 +57,7 @@ TimesigWizard::TimesigWizard(QWidget* parent)
connect(tsCutTime, SIGNAL(toggled(bool)), SLOT(cutTimeToggled(bool)));
connect(tsFraction, SIGNAL(toggled(bool)), SLOT(fractionToggled(bool)));
pickupMeasure->setChecked(false); // checked in the UI file to enable screen reader on pickup duration controls
tempoGroup->setChecked(false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth a comment in the code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though it’s the same comment as the line above? I actually copied the line but deleted the comment on purpose.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, missed that

@vpereverzev vpereverzev merged commit 9691f78 into musescore:3.x Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants