[MU4] Porting 3.5.2_backend fixes to master #6818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomanPudashkin
approved these changes
Nov 5, 2020
29 tasks
Harmoniker1
reviewed
Nov 5, 2020
Comment on lines
+89
to
99
| #ifdef ZITA_REVERB | ||
| { | ||
| 0, "Zita1" | ||
| }, | ||
| #endif | ||
| { | ||
| 2, "0.1" | ||
| }, | ||
| { 3, "440" }, | ||
| { 4, "1" }, | ||
| { 5, "1" } |
There was a problem hiding this comment.
Why only change the first two and not all others?
There was a problem hiding this comment.
Because the code style check only wanted those. IMHO bad enough...
There was a problem hiding this comment.
This is the problem of introducing automatic check. Do we still get to vote for its expulsion from MuseScore? :)
There was a problem hiding this comment.
It comes with a price tag for sure...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.