Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #259771 : make tremolo between notes play correct rhythm when bet… #6838

Merged
merged 1 commit into from Nov 16, 2020

Conversation

AntonioBL
Copy link
Contributor

…ween tuplets

Resolves: https://musescore.org/en/node/259771

By using tick instead of actual ticks, the number of note divisions (tticks/t) is correctly computed (while if actualTicks are used in tticks, the number of ticks per division -t- must be corrected by the tuplet ratio).
Single note tremolos already use ticks instead of actualTicks.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@vpereverzev vpereverzev merged commit 425136c into musescore:master Nov 16, 2020
@AntonioBL AntonioBL deleted the twonotetremoloplayback branch November 18, 2020 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants