fix #24102 - pedal was always applied to top part of score #686
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code was assigning the "local" channel (index within instrument) to the pedal events rather than the actual midi channel. Fixed.
I notice that the loop through spanners here actually hits each pedal element twice. I don't understand the structure of the spanner map and can't say if that's normal or not. I might guess that it's once for the begin, once for the end of the spanner. But the code here actually creates both the pedal on and pedal off event both time. So we're actually getting two pedal ons and two pedal offs for each pedal marking (even if there is only a single staff). Seems harmless, and unrelated to the issue at hand, so I didn't mess with it. Someone might want to look at this, though.