Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #24102 - pedal was always applied to top part of score #686

Merged
merged 2 commits into from Feb 12, 2014

Conversation

MarcSabatella
Copy link
Contributor

Code was assigning the "local" channel (index within instrument) to the pedal events rather than the actual midi channel. Fixed.

I notice that the loop through spanners here actually hits each pedal element twice. I don't understand the structure of the spanner map and can't say if that's normal or not. I might guess that it's once for the begin, once for the end of the spanner. But the code here actually creates both the pedal on and pedal off event both time. So we're actually getting two pedal ons and two pedal offs for each pedal marking (even if there is only a single staff). Seems harmless, and unrelated to the issue at hand, so I didn't mess with it. Someone might want to look at this, though.

pedal was always being applied to top part of score rather than the part
actually applied to
@lasconic
Copy link
Contributor

I can't reproduce, the spanner map contains only one pedal spanner for me. However the pedal events are not exported in the MIDI file.

lasconic added a commit that referenced this pull request Feb 12, 2014
fix #24102 - pedal was always applied to top part of score
@lasconic lasconic merged commit 50e4dbb into musescore:master Feb 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants