New Export dialog #6885
Merged
New Export dialog #6885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, there is an Export dialog, where you can select exactly which score/parts you want to export and where you can access the export preferences.
This was referenced Nov 17, 2020
ecstrema
reviewed
Nov 17, 2020
| Icons::fileSave_ICON, | ||
| Qt::WindowShortcut, | ||
| ShortcutFlags::A_SCORE | ||
| }, |
There was a problem hiding this comment.
If you remove it from here, it means it won't be assignable to a shortcut anymore.
There was a problem hiding this comment.
Yes, that is intended. The idea is that there will be a single action for export, which opens the Export dialog, where you can select whether you want the score and/or the parts.
(That is the action above the deleted one, so you don't see it directly in the GitHub diff.)
vpereverzev
approved these changes
Nov 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I created a new Export dialog.
Design is made in collaboration with @Tantacrul.
I made this dialog to make it easy for the user to select exactly which parts he/she wants to export. Formerly, it was rather unclear what the export options would do. Now, the behavior is more consistent and predictable.
Furthermore, I added the export preferences to the dialog, so that they are more discoverable and easily accessible right when you need them.
I also restructured the File menu a little; I put the options in a bit more sensible order.
(On the page with MusicXML settings, a workaround was needed to make the text for the radio buttons wrap. I had to put the text in a separate label. I wanted keep the functionality of clicking the text to select the radio button, so I created a clickable label.)
Feedback is appreciated!
Score/MasterScore/Excerpt/Part?