Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE #6898

Conversation

IsaacWeiss
Copy link
Contributor

WIP rebasing of #6365. Once tests pass, these changes will be pushed to that branch and this PR will be closed.

- Fix #279071: "Don't Break" element creates hole at end of system
- Allow more than two measures to be grouped
- Allow adding/toggling NOBREAK by clicking palette
- Rename to "Group Measures"
- Adjust placement of break symbols
Co-authored-by: MarcSabatella <marc@outsideshore.com>
- Public before private
- Members prefixed with "m_"
…btypes 1/2/4

- Draw with font symbols instead of QPainterPath
- Automatically group measures and delete contents when adding MeasureRepeat
- Bring measure.h and measure.cpp in line with new code guidelines
- Hide rests by making measures (per MStaff) aware if they are part of measure repeat group
- Keep measures and element in sync at all times by handling (preventing/warning/special-casing) many user actions
- Add style options for numbering consecutive one-measure repeats
MMRests:
- Add vtests for old-style (all fonts), h-bar thickness and margin (Bravura)

MeasureRepeats:
- Add script tests for adding, cutting/copying with partial group selected, pasting into group, repeating selection from before group, executing split/join/insert/delete measure commands, adding repeat barlines, and adding time signature
- Add mtests for parts, MIDI, and MusicXML import/export
- Add vtests
- Update ref files
@IsaacWeiss IsaacWeiss closed this Nov 22, 2020
@IsaacWeiss IsaacWeiss deleted the gsoc-2020-measure-repeats-rebased-test branch November 22, 2020 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant