Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU4] Fix #312489 Harmony duration interpretation #6918

Conversation

jeetee
Copy link
Contributor

@jeetee jeetee commented Nov 23, 2020

Resolves: https://musescore.org/en/node/312489

Cherry pick of PR #6857 from 3.x to master

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • [N/A] I created the test (mtest, vtest, script test) to verify the changes I made

@jeetee jeetee changed the title Fix #312489 Harmony duration interpretation [MU4] Fix #312489 Harmony duration interpretation Nov 23, 2020
@jeetee
Copy link
Contributor Author

jeetee commented Nov 24, 2020

Here is a perfect example of the lexical wrongness of pointer notation combined with const:
Original code= Measure const * abc (= a pointer to a const Measure)
"Corrected"= Measure const* abc (= quickly misgrouped and misread as a const* to a Measure, which it isn't)

@jeetee jeetee force-pushed the mu4-312489-Harmony-duration-interpretation branch from a239b5d to 7625593 Compare November 24, 2020 00:08
@jeetee jeetee force-pushed the mu4-312489-Harmony-duration-interpretation branch from 7625593 to 6f28290 Compare November 24, 2020 00:15
@igorkorsukov igorkorsukov merged commit c19d1b4 into musescore:master Nov 24, 2020
@jeetee jeetee deleted the mu4-312489-Harmony-duration-interpretation branch November 24, 2020 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants