Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #297458: Provide extra non-toggled post-application versions of accidental commands #6921

Merged

Conversation

worldwideweary
Copy link
Contributor

Resolves: https://musescore.org/en/node/297458

Provides non-toggle accidental shortcuts like earlier version up to 3.2.3. Not sure if (non-toggle) is the best thing to call them for differentiation though, but it works.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@vpereverzev vpereverzev merged commit 6400932 into musescore:3.x Nov 24, 2020
igorkorsukov added a commit to igorkorsukov/MuseScore that referenced this pull request Feb 11, 2021
…d post-application versions of accidental commands
vpereverzev pushed a commit that referenced this pull request Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants