[MU4] Fix build, and warnings too #6925
Conversation
| #define BRAILLE_TREBLEMENT QString(";6") | ||
| #define BRAILLE_INVERTED_MORDENT QString("\"6l") | ||
| #define BRAILLE_MORDENT QString("\"6l") |
There was a problem hiding this comment.
These switched roles in SMuFL 1.3, which MuseScore uses since a short while.
| //case BarLineType::REVERSE_FINALE: // duplicate of the above, alternative name | ||
| case BarLineType::HEAVY: | ||
| case BarLineType::DOUBLE_HEAVY: | ||
| break; // ToDo ?! |
There was a problem hiding this comment.
@andreituicu how to deal with those? These got added to MuseScore recently.
Actually I don't think we should be ignoring them, at least report them as normal barlines?
| case SymId::ornamentMordentInverted: | ||
| return BRAILLE_INVERTED_MORDENT; | ||
| case SymId::ornamentShortTrill: | ||
| return BRAILLE_SHORT_TRILL; |
There was a problem hiding this comment.
As mentioned above, these switched roles in SMuFL 1.3.
| @@ -2481,6 +2488,7 @@ QString ExportBraille::brailleMarker(Marker* marker) | |||
| case Marker::Type::FINE: | |||
| return BRAILLE_FINE; | |||
| case Marker::Type::TOCODA: | |||
| case Marker::Type::TOCODASYM: | |||
There was a problem hiding this comment.
Got added recently, I guess it is OK to treat it the same as the 'normal' "To Coda", @andreituicu
Jojo-Schmitz
force-pushed
the
fix-build
branch
from
1abfe65
to
4bbfe76
Compare
|
needs fix code style |
Jojo-Schmitz
force-pushed
the
fix-build
branch
from
4bbfe76
to
8143416
Compare
|
done |
|
@Jojo-Schmitz needs fix mtest (or turn off it) vtests expectedly has broken |
|
OK, mtests passed, vtests not. Squashing ... |
Jojo-Schmitz
force-pushed
the
fix-build
branch
from
7df6545
to
378f706
Compare
Needs some input from @andreituicu (as this is related to #6343)