Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mu4] volta jump regressions 3.5.1 #6972

Merged
merged 2 commits into from
Dec 5, 2020

Conversation

jeetee
Copy link
Contributor

@jeetee jeetee commented Nov 30, 2020

Resolves: https://musescore.org/en/node/313751 and https://musescore.org/en/node/313772

master version of #6971

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

libmscore/repeatlist.cpp Outdated Show resolved Hide resolved
@jeetee jeetee force-pushed the mu4-volta-jump-regressions-3_5 branch from de1a69c to e7ab443 Compare November 30, 2020 09:10
@jeetee
Copy link
Contributor Author

jeetee commented Nov 30, 2020

Can we see a closer review of the failing mtest reason within the github actions?
Same mtest for mu3 were happy though..

@Eism
Copy link
Contributor

Eism commented Nov 30, 2020

@jeetee
TestRepeat::repeat65() readScore: cannot load </mtest/libmscore/repeat/repeat65.mscx> type

with error: Score::FileError::FILE_TOO_NEW
description: This score was saved using a newer version of MuseScore. Visit the %1MuseScore website%2 to obtain the latest version.

@Eism
Copy link
Contributor

Eism commented Nov 30, 2020

@jeetee please add error code output with description to the console. will be useful in the future
/mtest/testutils.cpp:140

@jeetee
Copy link
Contributor Author

jeetee commented Nov 30, 2020

I'll look into that, but mtest is currently missing as part of the project on MinGW/QtCreator by default for me; haven't looked into that yet.

So likely something changed here between build systems and or mu3 vs mu4 as well; as in mu3 this output at least was generated at one point. Or perhaps the mtests used to run under debug and now don't?

@vpereverzev
Copy link
Member

Looking for rebase and then I'll merge it

@jeetee jeetee force-pushed the mu4-volta-jump-regressions-3_5 branch from e7ab443 to de6dcad Compare December 5, 2020 12:17
@jeetee
Copy link
Contributor Author

jeetee commented Dec 5, 2020

happy times

@vpereverzev vpereverzev merged commit 046ef07 into musescore:master Dec 5, 2020
@jeetee jeetee deleted the mu4-volta-jump-regressions-3_5 branch December 5, 2020 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants