Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow windows build with vscode #7006

Merged
merged 1 commit into from Dec 4, 2020
Merged

Conversation

ecstrema
Copy link
Contributor

@ecstrema ecstrema commented Dec 3, 2020

Resolves: no issue in tracker

using msvc build.bat, this allows to build musescore with vscode.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@ecstrema
Copy link
Contributor Author

ecstrema commented Dec 3, 2020

Note that the other option to have a viable vscode config would be to add .vscode to .gitignore, so it that users could manage that themselves these settings themselves. It would however require more manual setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants