Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #313896 Portamento playdown not working #7015

Merged
merged 1 commit into from Dec 8, 2020

Conversation

ypoissant
Copy link

@ypoissant ypoissant commented Dec 3, 2020

Resolves: Glissando down playback not working when set to "Portamento"

Portamento style glissando going from a higher note to a lower note did not play like a portamento but played the two begin and end note.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Dec 3, 2020

I believe the commit title should be Fix #313896: Portamento playdown not working for the aute marking as fixed to work.

@ypoissant ypoissant changed the title Fix issue #313896 Portamento playdown not working Fix #313896 Portamento playdown not working Dec 3, 2020
@ypoissant
Copy link
Author

I just clicked on the wrong button prematurely. I edited the PR message. But I'm not sure if the direct link to the fixed issue is formatted correctly.

@Jojo-Schmitz
Copy link
Contributor

That's OK, it leads to it

@vpereverzev vpereverzev merged commit 86d660d into musescore:3.x Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants