[MU3] Leland style values update #7016
Conversation
vpereverzev
commented
Dec 3, 2020
vpereverzev
commented
- Updated default style values from newest Leland
- Resolved https://trello.com/c/Jef5H0PR
- Resolved https://trello.com/c/lju5Hxmz
vpereverzev
force-pushed
the
leland_style_values_update
branch
from
6e2edc4
to
5ce1ea7
Compare
vpereverzev
force-pushed
the
leland_style_values_update
branch
from
5ce1ea7
to
437fb96
Compare
| @@ -593,7 +593,7 @@ static const StyleType styleTypes[] { | |||
| { Sid::barGraceDistance, "barGraceDistance", Spatium(1.0) }, | |||
| { Sid::minVerticalDistance, "minVerticalDistance", Spatium(0.5) }, | |||
| { Sid::ornamentStyle, "ornamentStyle", int(MScore::OrnamentStyle::DEFAULT) }, | |||
| { Sid::spatium, "Spatium", SPATIUM20 }, | |||
| { Sid::spatium, "Spatium", 24.8 }, | |||
There was a problem hiding this comment.
At several places SPATIUM20 is used. With this change SPATIUM and Sid::spatium are not the same anymore.
Are we sure this doesn't cause any problems because both SPATIUM and Sid::spatium are expected to be same or one is used where the other should be?
There was a problem hiding this comment.
I limited myself to the changes here at Simon's request, let's see how this affects those elements that do not use it through the style, for some reason, and if something goes wrong, we will replace the value of spatium20 in the future
There was a problem hiding this comment.
If so, we should fix those places. But while Sid::spatium might have defaulted to SPATIUM20, certainly we always support changing that value, and a great many scores do, and overall, things work. We do find and fix bugs from time to time where things don't scale properly, but I don't remember any cases where it was on account of confusing these two values - normally just because we were forgetting to account for this at all, like in some particular layout(), draw(), or mag() function. Or we were missing it in spatiumChanged().
There was a problem hiding this comment.
Yeah, perhaps. Probably we'll need to replace direct usage of SPATIUM20 with styleD(Sid::Spatium) in the next PRs
