fix vtests #7048
fix vtests #7048
Conversation
ecstrema
force-pushed
the
fix-vtests
branch
3 times, most recently
from
7b78510
to
800e6aa
Compare
|
Oh oooops... This was my fault, with PR #7019. I changed it, with the idea to make it more convenient for the user, but didn't notice that it would cause problems here. Thanks for fixing it, @Marr11317 ! |
I could have changed it directly in the vtests, but thought that this change might annoy users that are regularly using this export function, since they would then have two different exported files for the same thing. e.g. |
|
Spaces in filenames are bad, if created by default |
| echo " <span>Current</span>" >> $F | ||
| echo " <span>Reference</span>" >> $F | ||
| echo " <span>After PR</span>" >> $F | ||
| echo " <span>Before PR</span>" >> $F |
There was a problem hiding this comment.
Maybe just "Before" and "After" are better? or ""change" or, even better "commit" rather than "PR"? Not sure whether vtests are (or should be) used only on PRs.
And they are used again on a subsequent commit to a PR too.
after 1f0c7ee
export for page number was changed from
"-%pageNumber"to" - %pageNumber"