Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable Save to Cloud option for Beta release #7054

Merged
merged 1 commit into from Dec 10, 2020

Conversation

cbjeukendrup
Copy link
Contributor

Resolves: https://trello.com/c/TiatpJIG/57-disable-save-to-cloud-option-for-beta-release

We need to prevent users trying to upload scores, since the version on MuseScore.com will still be using 3.5.2.
It doesn't make sense to update the MuseScore.com version until we are satisfied that 3.6 is stable.

(I hope this is the desired way to do this. Obviously it should be reverted again, at some point.)

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

We need to prevent users trying to upload scores, since the version on MuseScore.com will still be using 3.5.2.
It doesn't make sense to update the MuseScore.com version until we are satisfied that 3.6 is stable.
@Jojo-Schmitz
Copy link
Contributor

Maybe allowing for this in experimental mode? So we can test whether Save Online works at all?

@cbjeukendrup
Copy link
Contributor Author

@Jojo-Schmitz You should actually ask @vpereverzev, but I thought the point was that things could go wrong on musescore.com if 'too new' files would be uploaded.

@vpereverzev
Copy link
Member

We just can't upload anything since backend of musescore.com uses older version than ours. That's why we shouldn't confuse people.

@Jojo-Schmitz
Copy link
Contributor

If it were hidden behind the -x (experimental) option, there would be no confusion, but those knowing this could test, lika (also) the translations

@vpereverzev
Copy link
Member

vpereverzev commented Dec 9, 2020

no matter of unstable or experimental mode, you'll get problems with "upload score" feature, because of the backend of musescore.com

there is nothing to test here, it won't process your score anyway

@Jojo-Schmitz
Copy link
Contributor

You get that only after the attempts, after having seen the dialog(s) and its translation. No harm on the server, just a test drill

@vpereverzev vpereverzev merged commit 3d6b5f1 into musescore:3.x Dec 10, 2020
@cbjeukendrup cbjeukendrup deleted the 3.6beta-disable-cloud-save branch January 6, 2021 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants