Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU3] Don't show empty Inspector #7076

Merged
merged 1 commit into from Dec 19, 2020

Conversation

Jojo-Schmitz
Copy link
Contributor

for tremolos between notes if on tablature or not on half notes.
Also disable Inspector for system- and page breaks.

Resolves: issue discussed in the developers' chat on Telegram.

@Harmoniker1
Copy link
Contributor

Just do a for loop for all tremolos

@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Dec 12, 2020

That's exactly the added complexity we agreed on to not be worth the effort, as far as understood, isn't is?

Getting it to work on a list selection containing 'proper' and 'improper' elements would be relatively complex

@Harmoniker1
Copy link
Contributor

That's exactly the added complexity we agreed on to not be worth the effort, as far as understood, isn't is?

Getting it to work on a list selection containing 'proper' and 'improper' elements would be relatively complex

Without the complex check it's still possible to get an empty section sometimes, unless you delete the same kind of check for the specific option in InspectorTremolo::setElement()

@Jojo-Schmitz
Copy link
Contributor Author

it's still possible to get an empty section sometimes

How?

@Harmoniker1
Copy link
Contributor

If the first element is applicable but the second is not, the section would be shown, but due to the check in InspectorTremolo::setElement(), the style option is invisible, which is the only option

for tremolos between notes if on tablature or not on half notes.
Also disable Inspector for system- and page breaks
@Jojo-Schmitz
Copy link
Contributor Author

I see...

@vpereverzev vpereverzev merged commit c8c6052 into musescore:3.x Dec 19, 2020
@Jojo-Schmitz Jojo-Schmitz deleted the inspector-tremolo branch December 19, 2020 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants