Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/314646 = https://trello.com/c/TyNjUPAH/79-format-style-page-and-format-style-score-dialogs-broken
Fix #314646: Fix sizing of some pages in the Edit Style Dialog
And make sure it will also work on smaller screens by using a Scroll Area for the most critical pages.
Style dialog: reduce width of some pages and add some more scroll areas
To make sure it also looks and works nice on smaller screens and to prevent the side bar from becoming wider and smaller for each page.
And the Tab order is cleaner than ever before!
Show Style Dialog always non-modally and bring it to front if already open (Follow up for PR Fix #302990: Set Style Edit dialog to be non-modal to allow score traversal when s… #6845)
In Format > Style…, the dialog was shown non-modally, but when you opened it from a context menu or by double-clicking the header or footer, it was shown modally. Now, it will always be shown non-modally.
When the dialog was already open but in the background, and you did something to open it again, nothing would happen. Now, the dialog will be brought to front in that situation.
Fix warning about icon file not being found
At some places in the Style dialog, the name for the reset icon was specified without the
:/
prefix, likedata/icons/edit-reset.svg
instead of:/data/icons/edit-reset.svg
. That produced a runtime warning (but remarkably, the icon did show up correctly).Here is a GIF showing all the pages of the style dialog:
![Style Dialog](https://user-images.githubusercontent.com/48658420/103038856-c2fd5200-456f-11eb-95a4-ffa25f26c31d.gif)
And here is a capture of the dialog on my 21,5" screen (4096 × 2304), to get a better idea of the size:
![Style Dialog on 21,5 inch screen](https://user-images.githubusercontent.com/48658420/103040105-c47c4980-4572-11eb-911c-b8a958e98cbe.png)
If necessary, the user can resize the dialog even further down.