[MU3] Fix #314696: Ties end at wrong note #7155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves: https://musescore.org/en/node/314696. When reading the properties of a tied note from a 2.x score, check to see if the specified pitch matches the pitch of the note at the beginning of the tie. If the pitches do not match, then print a debug message to the console, and set the pitch of the new note to match the pitch of the starting note.
|
This worked to fix the original example, but it does not fix the latest example posted to the issue thread. In fact, it makes it worse. I may take another look at what might be done to solve this issue of importing ties from certain 2.x scores, but I think the first step is to revert this change. Truth be told, it was definitely a hack, and not a good one at that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/314696.
When reading the properties of a tied note from a 2.x score, check to see if the specified pitch matches the pitch of the note at the beginning of the tie. If the pitches do not match, then print a debug message to the console, and set the pitch of the new note to match the pitch of the starting note.