Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #305215 : Crash when importing a file with an incomplete tuplet #7208

Merged
merged 1 commit into from Jan 11, 2021

Conversation

AntonioBL
Copy link
Contributor

Resolves: https://musescore.org/en/node/305215

This PR inverts the order of fillGapsInFirstVoices() and resetTuplets(), as suggested by Leon Vinken in the issue tracker.
It also introduces fraction calculation in pass 1 of the import to determine measure duration, and it tries take into account small residuals deriving from integer rounding errors.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants